Fix empty editor bug #9996
Open
Fix empty editor bug #9996
+112
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 |
nstrayer
requested review from
dhruvisompura,
midleman,
rodrigosf672 and
seeM
src/vs/workbench/contrib/positronNotebook/browser/PositronNotebookEditor.tsx
Show resolved
Hide resolved
|
@nstrayer can you unskip this test to confirm it passes: |
dhruvisompura
previously approved these changes
Oct 16, 2025
src/vs/workbench/contrib/positronNotebook/browser/PositronNotebookEditor.tsx
Show resolved
Hide resolved
… we actually update the active notebook instance.
nstrayer
force-pushed
the
positron-nb-blank-editor-fix
branch
from
986571f to
01f8681
Compare
seeM
previously approved these changes
Oct 20, 2025
There was a problem hiding this comment.
The move to getActiveNotebook is great. getAllPositronNotebookInstances could be fine but I think it can also differ from listInstances -- at least, upstream notebook editor widgets can exist that are not visible. I don't think we have that yet, but not sure if we may in future?
Nit: may want to name it getNotebookInstanceFromEditorPane to match upstream's getNotebookEditorFromEditorPane
nstrayer
force-pushed
the
positron-nb-blank-editor-fix
branch
from
01f8681 to
7d11fd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #9849
The editor-dissapearing bug was caused by improper storage of the react renderer in the notebook editor. Because of this when navigating back to the notebook the editor would not realize it had rendered before and restart everything which ran into bugs with things like disposed objects etc.
This PR makes sure that we actually store the react renderer to prevent premature cleanup.
Release Notes
New Features
Bug Fixes
QA Notes
You should be able to open a notebook then navigate away from the tab (make it not visible at all) and back and the notebook should still show up.